On Wed, Nov 19, 2008 at 10:14:38AM -0600, Shawn Walker wrote: > Brock Pytlik wrote: > > Webrev: > > http://cr.opensolaris.org/~bpytlik/ips-5206-v1/ > > > > Bug: > > http://defect.opensolaris.org/bz/show_bug.cgi?id=5206 > > > > This addresses some of the memory use issues with the depot. The bug > > report contains the analysis, but in short, this begins to address the > > issue, but doesn't sole it entirely. > > catalog.py: > line 288: I'm assuming this is a function to signal that a query is > *finished* as opposed to check if it is. Can you add a docstring? I > almost expected a bool return value.
Maybe calling it "finish_query()" is clearer? I agree that the function name sounds like it should return a boolean :) -Brad _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
