> Webrev:
> http://cr.opensolaris.org/~bpytlik/ips-2701-v1/

server/catalog.py:

  - lines 134-137:  Perhaps it would make sense to set a
    default_index_root in this class.  Then if index_root isn't
    initialized, set index root to default.  This means that you don't
    have to go through all of the norpath/join gyrations that this code
    currently uses.  You can simply say:

    if self.index_root != self.default_index_root:
        <pass extra argument to indexing process>

feed.py:

If you have a writeable scratch area, shouldn't you be able to save the
feed information there instead of continuing to re-generate it every
time a client looks at the feed?  I see a bunch of if scfg.is_read_only()
checks that don't have any associated logic for dealing with the
possibility that you may be able to write somewhere else.  How is this
being handled?

Thanks,

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to