Hi all,
After review by David, the list_build_files.py script has been
adjusted, to require a mandatory build number. Usage is now:
$ python list_build_files.py -h
Usage:
list_build_files [OPTION...] build-number
-d, --debug
Turn on debugging.
-h, --help
Show this help message
New webrev at:
http://cr.opensolaris.org/~richb/pkg-5292-v3/
Thanks.
-------- Original Message --------
Subject: Re: [pkg-discuss] Code review request for opensolaris
packaging bug #5292
Date: Mon, 24 Nov 2008 12:44:29 -0800
From: Rich Burridge <[EMAIL PROTECTED]>
To: pkg discuss <pkg-discuss@opensolaris.org>
References: <[EMAIL PROTECTED]>
<[EMAIL PROTECTED]>
[EMAIL PROTECTED] wrote:
> Just a few nits about path manipulation. The pydoc on os.path may be
> useful. That's the generally platform neutral way of handling paths in
> python.
Are we ever going to run this on anything but an OpenSolaris platform? :-)
> Given that, I might make the following changes.
>
> 49: use os.path.curdir instead of "."
> 74: use os.path.sep instead of "/"
Okay. So changed.
New webrev at:
http://cr.opensolaris.org/~richb/pkg-5292-v2/
Thanks.
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
