All the python changes look fine to me. I'm not the person to speak for the css changes though :)
Thanks, Brad On Fri, Dec 05, 2008 at 11:45:00AM -0800, Brock Pytlik wrote: > Thanks for catching this Shawn. I didn't quite grok that the web page > search took a different entrance into the depot search than pkg search > -r did. > > This LGTM. > > Brock > > Shawn Walker wrote: > > Greetings, > > > > The following webrev contains fixes for the following bugs: > > > > 5629 depot web search needs to limit result set size > > 5638 depot web search broken due to changes for bug 5212 > > > > Note that these changes are dependent on the ones I made for bugs 5541, > > 5609, 5610, 5611, and 5612. This should be the last change needed to > > address the search issues we discussed earlier this week. > > > > webrev: > > http://cr.opensolaris.org/~swalker/pkg-5629-5638/ > > > > Change Summary: > > * Added server_api_versions.txt to document changes to the server API > > > > * Bumped server api version to 1 due to incompatible search change > > > > * Fixed VersionException showing up as an unprintable instance object in > > traceback. > > > > * Fixed traceback when printing VersionException > > > > * Added text to indicate how many record(s) were found when searching > > > > * Removed usage of cgi.escape in favour of using Mako's built in html > > escaping from depot facing templates > > > > * Changed search to have a hard-coded limit of 100 results for now to > > prevent searches that aren't specific enough from causing resource > > issues (memory footprint, server cpu time, page size, etc.) > > > > * Changed search to warn a user when more results were found than can be > > shown (currently 100) and to suggest that they refine their query and > > try again. > > > > Cheers, > > > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
