LGTM. I'm not sure I'd know if something was wrong, but the samples seem to work and look fine, so +1 to this getting in to let the next set come in.
Brock Shawn Walker wrote: > Shawn Walker wrote: > >> Shawn Walker wrote: >> >>> Greetings, >>> >>> The following webrev contains fixes or changes for the following bugs >>> and RFEs: >>> >>> 5541 opensolaris.com theme desired >>> 5609 "default" depot theme doesn't show shortcut icon >>> 5610 web statistics tracking js not referenced properly in sun.com, >>> opensolaris.org themes >>> 5611 search page displays results header instead of search suggestions >>> 5612 index page should show repository description >>> >>> webrev: >>> http://cr.opensolaris.org/~swalker/pkg-depot-fixes/ >>> >> Before I forget (too late!), you can see the updated sample themes in >> action here: >> >> default: >> http://ipkg.sfbay:8009/en/index.shtml >> >> opensolaris.com: >> http://ipkg.sfbay:8010/en/index.shtml >> >> opensolaris.org: >> http://ipkg.sfbay:8011/en/index.shtml >> >> sun.com: >> http://ipkg.sfbay:8012/en/index.shtml >> >> Also, I've added the various site-specific TOU, legal, etc. links to >> each theme's page footer. >> > > I still need reviewers for this as it is a blocker for my forthcoming > fix for web search and it is needed to meet the depot requirements we > discussed in this week's team meeting. > > Thanks, > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
