> > 1. Does switching from unbuffered output to buffered output affect the > > correctness of any operations that we're performing? > > Um. I highly doubt it. What kind of problems, if any, might be expected? > > > 2. The pkgsubprocess module used pspawn to reduce the as_dup overhead > > when forking in low-memory situations. I'm assuming that in most cases > > it's not a problem to allocate 128k. However, I would be curious if > > this is likely to cause trouble if we're performing an install in tight > > memory conditions. > > I'd be curious, too. I'm not going to fire up VirtualBox with successively > smaller memory limits (by 128k apiece) to find this out. I think if we're > low enough not to have 128k, it's likely not to help much to discontinue > the use of the buffer. > > > Do we actually care about the output that gets returned from the driver > > actions or the indexer? I had thought we were simply checking the return > > code in these cases? > > I'd like to do more with the output from *_drv, but it's not proven to be > terribly feasible. > > I can make this change just for cpiofile if you believe that this is a > serious risk in other parts of the code.
I don't know the answer to either of these questions, but I thought that I should ask. If you think this is safe, go ahead and make the change. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
