Danek Duvall wrote: > On Mon, Dec 08, 2008 at 09:48:23AM -0800, Rich Burridge wrote: > > >> 5141 gen_os_files.py doesn't correctly handle packages that are no >> longer classified. >> http://defect.opensolaris.org/bz/show_bug.cgi?id=5141 >> http://cr.opensolaris.org/~richb/pkg-5141-v2/ >> > > Just nits, really. > > line 87: space before comma >
Okay. > line 135: I don't understand why you're using tokens[1] now instead of > tokens[0] -- the pathname you're passing in is the same, isn't it? > Sorry, I didn't understand this one. tokens[1] is the build number part of the current pathname. The debug message is simply there to print it out. > line 195, 196: category, sub_category = tokens. Wrap that in a try block > instead of the if statement on line 190, too. > Okay. New webrev at: http://cr.opensolaris.org/~richb/pkg-5141-v3/ Thanks. _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
