LGTM.
One additional possibility would be to add asserts in the
Image.set_property and unset_property methods that would also disallow
this, just in case another client tries to do this.
Thanks for fixing this.
Tom
Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issues:
4372 property set commands should display error for
preferred-authority property
webrev:
http://cr.opensolaris.org/~swalker/pkg-4372/
Change Summary:
* Changed client to exit with code of 1 if preferred-authority property
is provided to set-property or unset-property commands.
* Updated pkg(1) man page to explicitly state that these commands cannot
be used to change the preferred authority and to use set-authority instead.
* Added test suite test to ensure this works as expected
* Fixed printing of error messages for set/unset property commands
Cheers,
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;SWI Install/Update Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[email protected]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
