This LGTM,with one exception. line 665 - do we need to do it in the gobject?
best Michal Padraig O'Briain wrote: > I found that the original webrev did not work properly when initial > category was not the default, i.e. after bug 5738. I have fixed the > problem by always doing the accessibility stuff in an idle handler. > > The new webrev is at http://cr.opensolaris.org/~padraig/ips-5914-v2/. > > Further comments below. > > On 01/21/09 10:42, jmr wrote: >> Padraig - looks good few comments: >> >> Does this cover minimize and maximize as well as resize? > > Yes. >> 411 + # When the size of the application_treeview >> changes >> 412 + # we need to set image descriptions on >> visible status icons. >> 413 + >> self.w_application_treeview.connect('size-allocate', 414 >> + self.__application_treeview_size_allocate, None) >> >> >> I can see that this is referring to what's on the screen and not the >> model but would be good to change 3 to a All Caps var to clarify: >> > Done. >> 499 + # Status Column is 4th column in the >> TreeView >> 500 + obj = >> self.a11y_application_treeview.ref_at( >> 501 + >> int(model.get_string_from_iter(itr)), 3) >> I assume this is minimizing what needs be updated for performance: >> >> 504 + def __set_accessible_visible_status(self): >> >> > Yes. > >> JR >> >> Padraig O'Briain wrote: >>> The webrev http://cr.opensolaris.org/~padraig/ips-5914-v1/ fixes >>> bug 5914 Images in "Status" column need accessible descriptions >>> >>> The fix ensure that image description is set on the accessible object >>> corresponding to the status icon >>> for each visible status icon. >>> >>> Padraig >>> _______________________________________________ >>> pkg-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >>> > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
