Looks like 6303 and 3821 are duplicates.
src/Makefile:
- line 55: Why bother having this line?
src/um/Makefile:
- line 136: Does this blank line prevent the following commented-out
lines from ever getting printed out?
- line 152ff: This is almost $(ROOTCOMPONENTS); would it be worth using a
common variable so you don't have to remember to update both places,
and remember what belongs in one and not the other?
- line 194: Could $(ROOTAPPICONSHARE) be $(@D) here and in the other
rules? That might also allow you to combine the rules into a smaller
set, if you cared to.
Looks fine in general. Thanks for doing this.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
