[email protected] wrote: >> Looking for a code review of the proposed changes for >> the fix for bug #5115: >> >> http://defect.opensolaris.org/bz/show_bug.cgi?id=5115 >> Package Manager dependencies are not ordered, and are >> missing other packages >> >> Webrev is at: >> >> http://cr.opensolaris.org/~richb/pkg-5115-v1/ > > A general question - do we know why some of the dependencies aren't > being auto-discovered?
I don't. Maybe Danek or Bart have some ideas. I can also investigate further if you like. > src/util/distro-import/100a/common/SUNWii > src/util/distro-import/100a/common/SUNWrdc > > In order to maintain the convention of the other import files, > please place the dependencies at the end of the file (before > "end package") > > src/util/distro-import/100a/common/SUNWspsv > > The dependency on SUNWscm is already there so adding this is > superfluous. Okay. So changed. > src/util/distro-import/Makefile > src/util/distro-import/unbundleds/AVS > > As this cluster is made up of packages in the "entire" > incorporation, it needs to be published every build (namely, > it's not an unbundled). As such, the import file should not be > under unbundled but rather under <build #>/common and an > appropriate line added to <build #>/redist_cluster. Good point. Adjusted accordingly. > I too don't particularly like the 11.11 version number - I > actually don't see it being used by the WOS meta-cluster at the > moment (as of build 106) but in any case, that version number > is likely due due to the current minor portion of the SunOS > under development being "11". I believe a suitable value is > "0.1" as with the other such clusters such as those defined in > 101a/common/StorageNAS and 101a/common/StorageServer. It's now "0.1". New webrev at: http://cr.opensolaris.org/~richb/pkg-5115-v2/ Jim, I'll send you separate details on how you can test these updated packages. Thanks. _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
