> >> http://cr.opensolaris.org/~johansen/webrev-6332/ > > > > In pull.py, the _() function needs to wrap just the literal string there, > > and not the arguments to %, or the translation won't ever work. > > Not only that, named format specifiers need to be used anytime more than > one exists in a string: > > _("%(fmri)s is an illegal fmri: %(error)s") % { "fmri": pkgfmri, "error": e) > > ...because not every language uses the same sentence structure (i.e. > subject verb object, etc.).
I didn't realize we had introduced any standards for internationalization. Do we have this documented anywhere? I've updated the webrev. Thanks again for the review. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
