I have been talking with Padraig offline about this webrev and it looks good to me.
best Michal Padraig O'Briain wrote: > > > -------- Original Message -------- > Subject: [pkg-discuss] Code Review for 6239 time.sleep() should not be > called when getting package info > Date: Wed, 28 Jan 2009 08:27:13 +0000 > From: Padraig O'Briain <[email protected]> > To: [email protected] > > > > The webrev http://cr.opensolaris.org/~padraig/ips-6239-v1/ fixes > 6239 time.sleep() should not be called when getting package info > > This change used TYPE_AHEAD_DELAY to determine when to start getting the > required information. > This is the same technique as is used to determine when to start > searching when the user types in the search box. > > The idea is to not start getting the package info until the user has > stopped scrolling. > The previous implementation created a thread for each package selection > and then slept a second and determined whether the selection had > changed. If it had the thread terminated; if not the package info was got. > > The function __show_info and __show_licenses are invoked in an idle > handler. They invoke __show_package_info or __show_licenses_info in a > separate thread. > > In on_package_selection_changed I have converted the iterator to a tree > path as the iterator does not persist beyond the signal. > > Padraig > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
