On Fri 06 Feb 2009 at 02:29AM, Dan Price wrote: > > Verbal consensus was reached this week that, with this change, no one > may "dirty" the build. It is irritating and danger-prone to have > broken, noisy makefiles. And cleaning up broken makefiles after the > fact is incredibly time consuming: this work consumed 6+ hours of > solid effort.
Dear John, Four days after I annonced this policy, the following changeset 866:1768eb95fd29 John Rice <[email protected]> 6355 Add StartPage to PM has already broken it. You must fix this, or I will ask that your changes be backed out. There is a clearly coded example in the makefile (for the help files) which does exactly what you want. The policy is included below for reference. Please read and understand it before doing any further putbacks. -dp > So: Your makefiles have to be written correctly from here on out. > > - An incremental build when nothing has changed must do nothing > except traverse makefiles. Like this: > > $ make > /net/xanadu/aux0/ws/makefile-fixes/src/web > /net/xanadu/aux0/ws/makefile-fixes/src/gui > /net/xanadu/aux0/ws/makefile-fixes/src/um > /net/xanadu/aux0/ws/makefile-fixes/src/po > /net/xanadu/aux0/ws/makefile-fixes/src/util/misc > /net/xanadu/aux0/ws/makefile-fixes/src/brand > /usr/bin/python setup.py build > running build > running build_py > running build_ext > $ > > - clobber and clean should work properly: > - clean should delete *all* artifacts of the build that occur > in the source hierarchy (like .o files). > > - clobber should depend on clean, and should destroy from the > proto area all components which are placed there by "install" > > - Test each target with a clean workspace (i.e. hg clone your > workspace to get a virgin one, and test builds there). Test > install targets by deleting the proto area and rebuilding. > > Thanks, > > -dp > > -- > Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss -- Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
