Nits:
client/image.py
trailing space on line 1012
manifest.py
line 325: I think either this should be the variable 'a' or this
function shouldn't take 'a' as an argument. I'm betting it works either way.
I think I understand how things work, things put in "excludes" are
functions which when called for an action, return False if it should be
excluded, and True if it should be included. Given the existing code, I
understand why it was done this way by I found it counterintuitive for
me. Ideally, my preference would be that the not on line 325 was instead
encoded in variant code (ie exclude_action(self, action): return not
self.allow_action(action)), or in lines 1092/1095 of manifest.py. If
nothing else, please comment the behavior of excludes.
Other than that, looks great to me.
Brock
[email protected] wrote:
Looks good.
-j
On Tue, Feb 17, 2009 at 05:31:13PM -0800, Bart Smaalders wrote:
This fix saves 122 MB of memory when upgrading my desktop
from 106 to 107.
http://cr.opensolaris.org/~barts/6652/
- Bart
--
Bart Smaalders Solaris Kernel Performance
[email protected] http://blogs.sun.com/barts
"You will contribute more with mercurial than with thunderbird."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
