Tom Mueller wrote:
Please review this changeset for a set of Windows related problems:
2747 make per-package progress output work on Windows
5947 File in use not detected during delete of a package on Windows
6020 pkg.depotd fails to deliver incremental catalog updates (Windows
Vista)
6021 incremental catalog update size calculated incorrectly on Windows
6697 Windows rename/remove tests fail due to unwanted catalog refresh
6700 TestCatalog.test_bug_5603 test fails on Windows (stat problem)
webrev: http://cr.opensolaris.org/~tmueller/ips-winfix-1/
Many of these are very simple changes. The one more complicated one
is the introduction of a new exception type,
api_errors.FileInUseException for making the user aware that a file is
in use so an operation cannot be performed. This is defined as a
special case of a permissions exception. In the install path, the
except block for the permissions exception was already there. I added
a new block in the uninstall path and made this specific to the new
exception to preserve old behavior. This could possibly be generalized
to catch permissions exception there too.
For 2747, I chose to keep the name of the progress tracker as
"FancyUNIX" even though it works on Windows now too. That could be
debatable.
Thanks
Tom
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Updatelog.py
Line 161 and 180: I don't understand the changes being made here.
Other than that, LGTM.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
