Padraig:
As I've said, this is code that is/was still in very active development.
You're seeing various bits of debugging output. The searches you've
tried before should be succeeding better now, several performance fixes
went in so that they at least complete before a timeout happens.
Those debugging lines should be removed in this new webrev.
http://cr.opensolaris.org/~bpytlik/prelim_search_v1_v5/
Everyone:
I believe this webrev to now be totally functional modulo one
intermittently failing test case (t_pkg_search.test_4048_2 if you're
scoring at home) which I'll look into tomorrow. I've done a first pass
at cleaning up the formatting and removing commented lines, so it's the
first one I feel comfortable asking for substantial feedback on. I know
there's still a fair bit of dead code to be removed, and much doc
strings/documentation change to be made and a fair amount of performance
to try and find on the server. That said if this code was bug free (I'll
wait for the laughter to die down) I think from a feature/performance
point of view, it's ready, though it's quite possible some new
combination of queries will prove that not to be the case.
Shawn:
I'd like your advice if you have the time on how to handle the
combination of versioned_url open, 404 errors, and retries. Right now, I
use 404 if the version isn't supported, and 410 if the search found
nothing (so that versioned_url knows not to retry). If I've understood
everything correctly, now that we're at CP3.1.1, we can use a status
message to distinguish those two cases (like we did a long time ago). If
so, can you point me to an example of how to set it?
Thanks,
Brock
Padraig O'Briain wrote:
Brock,
When I started packagemanager I got 431759 lines of output.
I have attached the first and last ten lines.
Padraig
On 03/04/09 21:05, Brock Pytlik wrote:
Padraig O'Briain wrote:
As you can see search for <info.classification:games> worked.
However search for <SUNWipkg:attribute:fmri:> did not. It also
seemed to crash the server which was unavailable for some time
before becoming available again.
Padraig
bash-3.2$ pkg search -s http://ipkg.sfbay:40123
'<info.classification:games>'
PACKAGE
pkg:/[email protected]
pkg:/[email protected]
pkg:/[email protected]
pkg:/[email protected]
pkg:/[email protected]
pkg:/[email protected]
pkg:/[email protected]
pkg:/[email protected]
pkg:/[email protected]
pkg:/[email protected]
pkg:/[email protected]
pkg:/[email protected]
pkg:/[email protected]
pkg:/[email protected]
pkg:/[email protected]
pkg:/[email protected]
Good
bash-3.2$ pkg search -s http://ipkg.sfbay:40123
'<SUNWipkg:attribute:fmri:>'
pkg: Some servers failed to respond appropriately:
http://ipkg.sfbay:40123: timeout
I'll think about how to fix this.
bash-3.2$ pkg search -s http://ipkg.sfbay:40123
'<info.classification:games>'
pkg: Some servers failed to respond appropriately:
http://ipkg.sfbay:40123: timeout
When I ran this again, it worked, though it took longer b/c the
server was still under heavy IO load from the first search.
Brock
On 03/04/09 11:54, Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/prelim_search_v1_v4/
Fixes pkgdefs, boolean search, other various bugs. Adds a number of
tests. A depot running under this version shouldn't die or have
memory blow up with searches of '*' or other fun combinations. Feel
free to try AND and OR in your queries as well. While I'm sure
there are bugs waiting to be found, I'm not aware of any potential
pitfalls at the moment. In other words, my hope is to clean up the
files and have a real webrev out for review later today.
The depot on ipkg:40123 has been updated to these latest bits (and
also has had the content root set so pointing at it with a web
browser should work now though the search in the BUI hasn't been
updated to send search_v1 searches.)
Please let me know if there are either bugs you encounter or things
you don't like.
Thanks,
Brock
Brock Pytlik wrote:
It appears a change needs to be made to the pkgdefs/*. I'll talk
to some people and find out whether it's expected I need to modify
these files or not.
Brock
[snip]
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
