Shawn Walker wrote:
Greetings,
The following webrev contains fixes and enhancements for the following
issues:
5871 publisher apis desired
3682 pkg publisher should show mirrors in default listing
5071 provide direct way to change publisher to not use certificate
6843 problems with empty string for ssl_cert, ssl_key
6897 "authority" should be "publisher"
7046 client intent is not sent if same api object used for multiple
operations / reasons
====================================================================
I need at least two individuals to commit to reviewing this. Please
respond *before* reviewing if you can commit to reviewing this.
====================================================================
====================================================================
webrev
====================================================================
Updated webrev:
http://cr.opensolaris.org/~swalker/pkg-5871-2/
diff from last webrev:
http://cr.opensolaris.org/~swalker/pkg-5871-2/v1-v2.patch
Change Summary:
pkg.client.history
------------------
* Added RESULT_FAILED_CONFIGURATION constant.
* sorted RESULT constants
pkg.client.api_errors
---------------------
* Added BadRepositoryURISortPolicy
pkg.client.image
----------------
* Added deprecated notices to docstrings of functions that are intended
to be removed in a future release.
* Re-worked get_ssl_credentials to not use deprecated functions in
publisher class.
* Removed redundant "get_default_publisher" function; changed all
references to use get_preferred_publisher instead (equivalent
functionality).
* Removed unused set_publisher().
pkg.client.imageconfig
----------------------
* Added comments about properties that need changing once the move to a
new cfg_cache format has been made.
* Changed to read and write new sort_policy property for repository class.
pkg.client.publisher
--------------------
* Added note indicating that the publisher classes are considered part
of the public client api and all changes to it must be documented in
doc/client_api_versions.txt.
* Added comments explaining the purposes of repository collection types.
* Moved scheme lists for ssl support and supported protocols to new
constants SUPPORTED_SCHEMES and SSL_SCHEMES.
* Added URI_SORT_PRIORITY and URI_SORT_POLICIES.
* Fixed exception handling for URI priority and Repository attributes.
* Formatting fixes for docstrings.
* Added comments about uri removal.
* Added sort_policy attribute to Repository class to allow control over
sorting of repository URIs (mirrors, origins, etc.).
* Removed unused publisher.add_mirror, publisher.has_mirror,
publisher.is_disabled, publisher.num_mirrors, publisher.remove_mirror,
publisher.set_ssl_creds, publisher.set_ssl_key, publisher.set_ssl_cert,
and publisher.set_uuid functions.
* Changed publisher.set_uuid, publisher.set_prefix,
publisher.set_disabled to private functions used for the respective
properties only.
tests/api/t_imageconfig.py
--------------------------
* Updated to include sort_policy.
client.py
---------
* sorted imports in client.py
* changed CertificateError failure result to RESULT_FAILED_CONFIGURATION
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
