On Mon, Mar 09, 2009 at 01:57:58PM -0700, Bart Smaalders wrote: > Shawn Walker wrote: >> Shawn Walker wrote: >>> Shawn Walker wrote: >>>> Shawn Walker wrote: >>>>> Greetings, >>>>> >>>>> The following webrev contains fixes and enhancements for the >>>>> following issues: >>>>> >>>>> 5871 publisher apis desired >>>>> 3682 pkg publisher should show mirrors in default listing >>>>> 5071 provide direct way to change publisher to not use certificate >>>>> 6843 problems with empty string for ssl_cert, ssl_key >>>>> 6897 "authority" should be "publisher" >>>>> 7046 client intent is not sent if same api object used for >>>>> multiple operations / reasons >>>>> >>>>> ==================================================================== >>>>> I need at least two individuals to commit to reviewing this. >>>>> Please respond *before* reviewing if you can commit to reviewing >>>>> this. >>>>> ==================================================================== >>>>> >>>>> ==================================================================== >>>>> webrev >>>>> ==================================================================== >> >> Bart, Johnasen, I need your signoff on this last set of review fixes. >> Thanks. >> >> Updated webrev: >> http://cr.opensolaris.org/~swalker/pkg-5871-4/ >> >> diffs from last webrev: >> http://cr.opensolaris.org/~swalker/pkg-5871-4/v3-v4-part1.patch >> http://cr.opensolaris.org/~swalker/pkg-5871-4/v3-v4-part2.patch >> >> Properly completes fix for forgotten bug: >> 5373 pkg commands shouldn't traceback when client can't read a key/cert >> file >> >> Change Summary: >> * Fixed exception handling for CertificateError exceptions (I didn't do >> this right the first time around); this resolves bug 5373 >> >> * Simplified and cleaned up SSL cert display code for "pkg publisher" >> command >> >> * Fixed "pkg publisher" command to return partial failure code (3) if >> some of the SSL information couldn't be retrieved >> >> * Added tests to verify that exception handling is correct for certificates >> >> * Added comments explaining rationale for property declaration style in >> pkg.client.publisher >> >> * Fixed bug with uuid set during Publisher class initialization >> >> * Added test for uuid set >> >> * Merged with gate tip >> >> Cheers, > > > ship it. > > - Bart
+1 -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
