On Mon, Mar 09, 2009 at 06:14:45PM -0700, Brock Pytlik wrote:

>> directory.py
>>
>>   - line 51: use os.path.sep instead of "/"
>>
>> file.py
>>
>>   - line 61: use os.path.sep instead of "/"
>>
>> link.py:
>>
>>   - line 50: use os.path.sep instead of "/"
>>   
> Ok,, I'll fix those

Be careful here.  I commented a bit on this as well (but I'm much slower
than johansen, so I haven't finished my review yet), but this has impact on
Windows boxes.  Take a look at bug 1059 for a similar problem.

Anyway, I'll try to finish the review tomorrow so I can send it out.
Though if you want me to send out what I've got early, I can.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to