On Tue, Mar 10, 2009 at 02:35:45PM -0700, Bart Smaalders wrote:

> Fix is in bug report as well:
>
> diff -r ab191bd21d71 src/modules/client/actuator.py
> --- a/src/modules/client/actuator.py  Tue Mar 10 13:01:41 2009 -0500
> +++ b/src/modules/client/actuator.py  Tue Mar 10 14:28:24 2009 -0700
> @@ -268,7 +268,7 @@
>                  return self.__smf_svc_get_state(fmri) < 
> SMF_SVC_TMP_ENABLED
>
>          def __get_smf_props(self, svcfmri):
> -                args = (svcprop_path, "-cq", svcfmri)
> +                args = (svcprop_path, "-c", svcfmri)
>
>                  try:
>                          buf = self.__call(args)
> @@ -288,7 +288,7 @@
>                              args[0].lstrip("/")),) + args[1:]
>                  try:
>                          proc = subprocess.Popen(args, stdout = 
> subprocess.PIPE,
> -                            stderr = subprocess.STDOUT)
> +                            stderr = subprocess.STDOUT) # combine 
> stdout&stderr

Remove the spaces around the equals signs in the parameter lists.  Is the
comment really necessary there?

Otherwise, looks fine.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to