On Wed, Mar 11, 2009 at 05:07:25PM -0500, Shawn Walker wrote:
> Greetings,
>
> The following webrev contains fixes for the following bugs:
>
> 6574 repository creation ability desired
> 7301 pkgsend should support --help and -? for showing usage information
>
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-6574/
pkgsend.1.txt:
- line 27,28: "...of the target repository." Or you can use
"destination" as you have in the usage message, though "target" sounds
a bit more natural to me.
- line 40: Do you expect this to work on http at some point in the
future?
publish.py:
- line 67-74: Why not just enhance usage() and error() with an optional
argument in which you can pass the command name? You could also make
it take an optional exit code (defaults to 2), so you don't have to do
that weird trapping of SystemExit bit. You should probably convert the
other subcommands to use these instead of the plain error() and usage()
calls that are already there.
transaction.py:
- line 105: Should this exception take a scheme name and operation name
for a richer error message?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
