Danek Duvall wrote:
Turns out that if we imported a package, but dropped all the files from it,
we'd never use its license. This led to SUNWxvmipa not having any license
actions associated with it -- bug 5850. The fix is to pull all the license
actions regardless of whether we pull any files. The webrev is at
http://cr.opensolaris.org/~dduvall/pkg-bug5850/
This looks fine, but I'm concerned it will slow down the import since
two SolariPackageDirBundles will be created every package we process.
However, I'm not certain how much overhead there is in creating the
bundle object.
Maybe you could rework this so the license adding logic is in a nested
function, and the groups.values() loop still adds the licenses if it
encounters them. After the groups.values() loop, you could then process
anything it didn't?
Or am I imagining too much here?
At last check, a redist-import took about 45 minutes on ipkg.sfbay for
build 106, as a reference point.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
