Shawn Walker wrote:
Danek Duvall wrote:
On Thu, Mar 12, 2009 at 11:31:00PM -0500, Shawn Walker wrote:
Shawn Walker wrote:
...which is completely wrong. This looks like a long-standing
importer bug.
Did I say bug? I meant abuse :)
It's purposefully providing multiple values and expecting them the
resulting path attribute to be a list.
The question now is whether we should continue to allow this abuse or
make the importer deal with it.
Though the file action should be more robust, too. It should probably
raise an InvalidActionError if there are two path attributes.
The importer should probably stuff the new path in a different attribute,
and where it now checks to see if there's a second path, it should check
for that other attribute, and replace the path.
At least, that's my take. Bart owns chattr. :)
Bart, I'll do the work to fix this if you tell me if the above makes sense.
Cheers,
Solaris.py normally deals with this as follows (line 459, 474):
# chattr may have produced two path values
action.attrs["path"] = \
action.attrlist("path")[-1]
Solaris.py needs some significant surgery to work around the
problems here...
- Bart
--
Bart Smaalders Solaris Kernel Performance
[email protected] http://blogs.sun.com/barts
"You will contribute more with mercurial than with thunderbird."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
