Brock Pytlik wrote:
jmr wrote:
Michal LGTM, I've reviewed the patch, built and ran it against the
gate. It resolves all the issues raised below, I see you added some
support for retrieve.DatastreamRetrievalError, didn't know we needed
to catch this one.
One thing to note though when I was testing this I compared it
against pkg search -r for timings and noticed that for the CLI you
immediately get back search results against the preferred repo, which
I assume is cached locally. Is the CLI doing a local search first and
then a remote one?
The CLI doesn't do a local search unless you tell it to (with the -l
option). There's no caching going on that I can think of for remote
search.
Also the format of the error for servers not running search/1 is
poor. Can you log an API RFE against it thanks.
Some servers failed to respond appropriately:
http://pkg.opensolaris.org/contrib/:
http://pkg.opensolaris.org/contrib/ doesn't speak a known version of
search operation
http://osol-re.sfbay.sun.com/: http://osol-re.sfbay.sun.com/
doesn't speak a known version of search operation
https://pkg.sun.com/opensolaris/extra/: Internal Server Error (500)
This looks fine above but it wraps badly in the Dialog. The Exception
should be changed to give us a list of tuples, <server>,
<error_enum>, <error string>
We could then process them and decide how best to present them to the
user, if at all (we could eat Internal Server Error for instance).
Perhaps along the lines of:
This was something I wanted to fix but didn't for this changeset. It's
possible this won't get changed till the transport wad lands because
the exception is getting thrown by versioned url_open, which is called
in many places in the code. Please file the RFE, I just wanted to
explain why things are as they are right now.
OK - but does this mean that this will not be fixed for 06.2009? If
that's the case then we will need to put in some post processing
ourselves for this exception and I'd rather not if its just going to be
thrown away before 06.2009 is released.
Thanks,
JR
Thanks,
Brock
Packagemanager
----------------------------
The following repositories do not yet support Search All Repositories:
*contrib* (http://pkg.opensolaris.org/contrib/)
*opensolaris.org* (http://osol-re.sfbay.sun.com/)
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
