Brock Pytlik wrote:
manifest.py:
This code looks very client/image centric in that it sets an image as a
class variable, but I don't actually see anyplace where it has to be.
The only places I think we make use of the fact that we have an image is
in constructing the CachedManifest where we pass it into the Manifest
constructor, and for getting the path for the fmri's manifest. For the
first, as far as I can tell, we never actually use the image object that
we set in the Manifest object (at least we're not using it in the code
in manifest.py). For the second, could we just pass a function in which
translates a fmri to a manifest path/directory? That would remove the
client specific nature of the code. Maybe this won't have a clear use on
the server, but I don't see a reason to tie the functionality to the
client alone without a reason.
Hmmm I can do this by overloading set_fmri, but I was trying to
avoid modifying the server code.... mulling this over...
Other changes taken.
- Bart
--
Bart Smaalders Solaris Kernel Performance
[email protected] http://blogs.sun.com/barts
"You will contribute more with mercurial than with thunderbird."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
