Looks good to me.
Padraig
On 03/19/09 15:13, jmr wrote:
Thanks for the feedback Padraig, new webrev incorporating your
comments below and a few minor tweaks to the script. I have tested
this using a local apache server to host the updates and its working
well, with updates being fetched if the file is changed and PM picking
up the cache files if present. Also checked cpu usage and looks fine.
http://cr.opensolaris.org/~jmr/pm_6970_startpage_updateable_gate_19Mar_3pm/
JR
Padraig O'Briain wrote:
Some comments:
Why is the removal of startpage_ignite.pmg part of this webrev?
Start Page is being reworked and so we no longer need this png
In packagemanager.py should commented out code at lines 611-612 be
removed?
Done
What happens if SUNWipkg-um is not installed?
Then we just fall back to the default installed
/usr/share/package-manager/data/startpagebase/C/startpage.html
update-refresh.sh:
Copyright date should be changed to 2009.
Done
The comment at line 26 is not correct:
This script is run as part of a cron job at 0, 9, 12,
My understanding from pkg-update is that the cron job is run at
);30, 9:30, 12:30, 18:30, 21:30
Done
Padraig
On 03/19/09 14:17, jmr wrote:
Updated webrev to include changes for PM Start Page given input from
Glynn. Also makes Start Page appear on startup by default, this can
be turned off in Edit->Preferences. The Start Page will probably be
tweaked before release, but this should let l10n pick up most of
what's needed now.
http://cr.opensolaris.org/~jmr/pm_6970_startpage_updateable_gate_19Mar_2pm/
JR
jmr wrote:
Respin based on comments from Darren Kenny against the gate.
Thanks Darren.
- Quotes around "$ret" to try minimise adverse code executing
- Removal of what appears to me to be an excess download() call.
- Addition of 2>/dev/null to gconftool call since I've seen this
cause problems
before in some GNOME scripts.
http://cr.opensolaris.org/~jmr/pm_6970_startpage_updateable_gate_13Mar_1030am/
JR
jmr wrote:
Please use:
http://cr.opensolaris.org/~jmr/pm_6970_startpage_updateable_gate_12Mar_7pm
I had left a debug setting for default locale in the previous one.
JR
jmr wrote:
Hi,
This webrev provides a means to update the Packagemanager Start
Page files dynamically.
As part of the update_refresh.sh script that is run 5 times daily
(0,9,12,18,21) to update the catalog, a wget has been added to
fetch a start page tar gzip file (startpagebase-<locale
prefix>.tar.gz) from a URL specified in the PM gconf key
(/apps/packagemanager/preferences/startpage_url). This is
unpacked to a gui cache
(/var/pkg/gui/cache/startpagebase/<locale>) and picked up on
startup by the PM.
6970 Start page needs to be updateable
http://cr.opensolaris.org/~jmr/pm_6970_startpage_updateable_gate_12Mar_6pm/
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
