Tom Mueller (pkg-discuss) wrote:
This is a one-line code review question for an issue on Windows with the
new file: URI capability for pkgsend.
webrev: http://cr.opensolaris.org/~tmueller/ips-7535/
bug: http://defect.opensolaris.org/bz/show_bug.cgi?id=7535
Hi Tom,
Instead of special casing this just for pkgsend (and specifically in
FileTransaction), I think we need our own wrapper function for urlparse
put into misc. Then, *anywhere* we call urlparse, we need to call that
function instead.
The wrapper should check the scheme of the url, and if it is "file", it
should then make the url2pathname call. The other odd thing is that it
seems like url2pathname could be called on the entire url; not just the
path component.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss