John,
Great, thanks for this follow on.
Michal
jmr wrote:
Thanks Michal for taking a look:
Michal Pryc wrote:
John,
This looks good, but two questions:
glade file: I see that the string itself is not change so I suppose
this will not have an impact on the l10n?
Correct - no l10n impact.
packagemanager.py:
697 repo_pub_dict[origin.uri] = pub.prefix
This will solve problem if those repos are equal:
http://pkg.opensolaris.org/release
http://pkg.opensolaris.org/release/
http://pkg.opensolaris.org/release:80
http://pkg.opensolaris.org/release:80/
In this rev we have a one to one mapping between registered publisher
and uri, so the above code should be fine.
JR
If this will return only one publisher for all of those above and
there is no l10n impact then I think you can submit this to the gate.
best
Michal
jmr wrote:
Hi,
Here is a follow on webrev to the one Michal submitted, which:
- Enhances the output for the error, showing the publisher as well as
the uri
- Sizes the status bar warning triangle image to ensure SB doesn't
get too big, still bigger than I'd like but does help (save 4 pixels
in height).
- Added tooltip to warning button (uses text "Search All Repsoitories
Error, so no l10n impact, this string is the title of the dialog).
- Hide the warning triangle if in remote search mode, hit return to
do a remote search.
http://cr.opensolaris.org/~jmr/pm_7563_remote_search_followon_23Mar_3pm/
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
