OK - this commit went in on Friday to hit the l10n snap for cob Firday.
The patch just submitted is a direct follow on from this fix to clean up
a number of simple cosmetic issues and was not done until today as I was
not available before hand.
I thought this was exactly in the spirit of a follow on, but can see
from your description that this is not so.
I will ensure to follow the guidelines you have now posted.
JR
Danek Duvall wrote:
Okay, let's be clear about "follow-on" fixes. Please don't re-use a bugid
for a commit comment unless it's a quick, very small change that generally
comes within a few hours of the original putback. If you have to summarize
the change in four points, it's not a follow-up fix, it needs a new bug.
Follow-up fixes *must* have their essence summarized in two or three words
attached to the end of the synopsis, in parens. "(follow-on)" doesn't
explain what the change is, so it's not acceptable. Examples of reasonable
follow-up fixes might include:
- fix lint
- fix build
- fix typo
- add missing file
if folks don't get the hang of this, I'm going to ask that if you want to
commit a fix as a follow-up fix, you ask me first.
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
