Danek Duvall wrote:
On Wed, Mar 25, 2009 at 05:30:37PM -0700, Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-7358-v2/
server/catalog.py:
- line 105: Why not catch this at the same level as you do the
EnvironmentError? Do the indexing exceptions get thrown before the
EnvironmentErrors do?
Otherwise, looks fine.
Danek
The reason is that the shutil.rmtree and the call to self.refresh_index
on line 113 could throw an EnvironmentError as well. By catching the
environment error at the outer level, I catch it no matter where it
comes from, rather than duplicating the except block for the various levels.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
