Looks good to me.
One nit:
came should be come.
Padraig
On 03/27/09 08:46, Michal Pryc wrote:
Padraig,
You are right we need to check if args exists. I did spin new webrev
which also contains comment in the code why we need to check for two
exceptions.
http://cr.opensolaris.org/~migi/7642_low_disk_space_error_v1/
best
Michal
Padraig O'Briain wrote:
Michal,
It looks like you can get two exceptions which indicate out of space.
Is that so?
You do not check that uex.error.args exists before referencing it. Is
this OK?
Padraig
On 03/26/09 18:11, Michal Pryc wrote:
Hello,
The webrev fixes bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=7642
The bug describes situation when the user is installing package (api
in the execute stage) and there is disk out of space.
The proper behavior for such situation is to show dialog asking user
to run BE Management and clean up some space. The webrev fixes this
error so Package Manager/Update Manager/Web Installer behaves properly.
The webrev is at:
http://cr.opensolaris.org/~migi/7642_low_disk_space_error/
If someone is interested in reproducing this bug, I have prepared
script which is available at:
http://cr.opensolaris.org/~migi/7642_low_disk_space_error/test_low_disk_space_errors.sh
****
PLEASE DO ADJUST THIS SCRIPT AS THE NAME OF THE POOL IS *testips*
AND THE FILE WHICH IS BEING CREATED */test.pool* If you have such
pool or such file already on your system it will be removed.
****
Simply run:
pfexec ./test_low_disk_space_errors.sh
This script will:
- create zpool with 128M disk space
- setup local depotd
- send few sample packages to that depotd
- create local image
After those steps are done script will print what to do :)
To clean up please execute following commands:
- kill pkg.depotd
- clean up test pool:
pfexec /usr/sbin/zpool destroy testips
pfexec rm /test.pool
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
