Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-1873-v1/
Bug:
1873 generate_indices should ignore malformed and invalid actions
http://defect.opensolaris.org/bz/show_bug.cgi?id=1873
modules/manifest.py:
line 347: a docstring would be nice. Also, instead of checking to
see if log() was defined; I'd just check if log was defined, and if not,
use a lambda no-op function as the default to discard any calls to
log(). This shouldn't be a performance concerns as log() only gets
called during an error condition. This would also allow you to simplify
some of the later code that only calls log if defined.
line 392-394: so why assign cur_pos to arg before checking
return_line? Also, this looks like it could be moved into the else:
clause on line 402 so that the assignment won't happen unless needed.
lines 400-402: these need reformatting (> 80 chars)
tests/cli/t_pkg_search.py:
line 929: a docstring explaining the purpose of the test would be nice.
line 929ff: some linebreaks to spread out logical parts of the test
would be appreciated
Otherwise, looks fine.
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
