Danek,

Thanks for your comments.

New webrev is at http://cr.opensolaris.org/~padraig/ips-7645-v6/.


On 03/31/09 16:59, Danek Duvall wrote:
On Tue, Mar 31, 2009 at 03:33:39PM +0100, Padraig O'Briain wrote:

http://cr.opensolaris.org/~padraig/ips-7645-v5/

packagemanager.1.txt:

  - line 10: "hRUi" -> "hiRU" or "RUhi".
- line 41: "Update all packages in the specified boot environment." What
If the user chooses Update All menu or toolbar option in packagemanager and SUNWipkg or SUNWipkg-gui needs to be updated before proceeding with image update packagemanager reinvokes itself with this option after updating those packages to proceed with the image update.
 is the second sentence trying to say?

  - line 46: Is it "info_install" or "info-install"?  Is this option
    needed, anyway, because of the form on line 12?  This paragraph should
    come before line 36, to be in alphabetical order (by short option).

If you want to use a .p5i file with other options you need to use this option.
  - line 55: "ion" -> "on".  Space before "/aux0".

  - line 57: "aux09" -> "aux0".

  - line 73: "var" -> "/var".  "mainted" -> "maintained".

  - line 74: "start" -> "start-up".

  - line 88: add "pkg(5)" as well.

  - You don't need to capitalize "publisher" every time.

  - Perhaps you want to talk somewhere about invoking packagemanager with
    enough privilege to operate on an image you (as a normal user) don't
    own?

I had considered this but I did not see any reference to this in pkg(1) man page so I thought it did not to be mentioned.

updatemanager.1.txt:

  - line 32: Same comment here as on line 41 of packagemanager.1.

  - line 45: "aux09" -> "aux0"

  - line 71: reference "pkg(5)", too.

Why do you have changes to packagemanager.py and updatemanager.py in this
wad?

When preparing these man pages I found some options which we needed to remove and some did not work properly so those changes were to make to code behave as described in the man pages.

Danek
Padraig
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to