On Thu, Apr 02, 2009 at 01:19:02PM -0500, Shawn Walker wrote: > Danek Duvall wrote: >> Ed managed to get himself into a situation where a legacy action was >> broken, and "pkg fix" was stacktracing. There's a simple one-liner fix >> that I've just put into the bug report if anyone wants to look at it: >> >> http://defect.opensolaris.org/bz/show_bug.cgi?id=7907 > > Minor nitpick, instead of using self.destination_fmri.version, why not use > fmri.version and avoid the extra de-reference since it's insc ope?
It'd work just fine; I did it that way because it was a simple copy of the line in propose_destination(), and thus had less chance of screwing things up. :) > modules/actions/legacy.py: line 69: > This assumes that svr4 packages will always be arch i386; but isn't this > false now that we support SPARC as well? Indeed. :) Feel free to file a bug. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
