Shawn Walker wrote:
Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-7835-v1/
modules/client/imageplan.py:
line 786: this check should be switched around with empty_image
first to avoid the unnecessary check for index existence
ok
line 788: curious, is there a reason client_update_index can't
perform this automatically if needed?
Nope, there isn't off the top of my head. Would you rather have it in there?
line 818: i'd rather see this named image_is_empty() or
is_image_empty() to reinforce its boolean nature, and because it's a
function as opposed to a property
ok
modules/indexer.py:
lines 604-605: does every place that does a consistent_open need
this exception check? If so, line 127 needs it as well in this file.
Thanks, missed that.
modules/server/catalog.py:
lines 223-226: There doesn't seem to be much point to this since you
call ind.check_index_existence() again at line 227, and you're also
assigning to the variable cie which is never used. Did you mean to
change line 227 to be wrapped with the exception handler?
No, I meant to change 227 to use cie in place of the second call.
This changeset could also use some tests to verify that the new
behaviour actually happens as intended.
Ok. I'll assume you mean not rebuilding an index in a non-empty image,
since everything else is being tested already.
Thanks,
Brock
Cheers,
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
