david.co...@sun.com wrote:
I have prepared another webrev,
http://cr.opensolaris.org/~padraig/ips-7852-v2/.
I haven't gone through this in detail but a few comments:
Line 149 - Code in ON (or headed for ON) doesn't generally list bugids
or CRs in comments. Just explain the issue and don't reference the
bugid.
Parsing of /etc/passwd - how does this work given the name server
switch? You should be calling the Python equivalent of getpwnam(3C).
Thanks David,
Padraig you can change __find_root_home_dir() to use
pwd.getpwnam('root'), remove the bug ids from the comments and we should
be sorted:
>>> import pwd
>>> pwd.getpwnam('root')
('root', 'x', 0, 0, '', '/root', '/usr/bin/bash')
>>>
http://docs.python.org/library/pwd.html
JR
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
