> http://cr.opensolaris.org/~swalker/pkg-7774/
api.py:
- There are a few places in this code where you have a blanket
exception handler that will log the error and re-raise it.
Are there any layered api exceptions that this might catch and
record twice?
bootenv.py:
- line 153, 163-173: This is a nit, but it would be easier to read
this if success were switched to failure, and the conditions
inverted. If failure is a little more straight forward than if not
success.
The rest looks fine to me.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
