[email protected] wrote:
On Tue, Apr 07, 2009 at 06:20:45PM -0700, Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-7878-v1/
indexer.py:
- Instead of hard-coding the buffering size to 131072, it would be
better if you defined a constant for the buffer size and used that
instead.
Thanks for reminding me, I've been meaning to do that.
- line 269 & 270: Could this be re-written as:
if self.old_out_token is not None and self.old_out_token >= token
You'd save yourself a level of indendation here.
Good idea.
- line 393 & 394: Similar comment as the previous one. Can you
coalesce these two conditionals into one?
Yep, will do
Otherwise this looks fine to me.
Thanks for taking a look :)
Brock
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
