LGTM
Michal
Padraig O'Briain wrote:
This looks to me.
Padraig
On 04/07/09 12:28, jmr wrote:
Hi - this webrev addresses the need to return the correct 2009.06
release notes for x86 and sparc machines for the PM, UM and CLI. We
are sharing a common function between all the clients for this. In
both PM and UM the release notes are now clickable, in the CLI right
clicking on the link allows you to Open Link.
http://cr.opensolaris.org/~jmr/pm_6358_7550_release_url_07April_12noon/
6358 Release Notes message after Update All needs to be updated
7550 Release Notes message after image-update needs to be updated
7353 Release notes URL should be clickable
For this rev the date is hardcoded, in future revs when it is possible
to get general attributes from packages using api.info() we will fetch
this information from the SUNWsolnm package that delivers /etc/release.
JR
jmr wrote:
Thanks for the review Shawn, I'll respin this tomorrow with your
comments and add in the support to PM.
JR
Shawn Walker wrote:
jmr wrote:
Hi,
This webrev solves a few issues with the Update All Completed
dialog. It makes the release notes link clickable and it auto
generates the url using the release number in the /etc/release
file. I have tried to make sure this reuses only strings that are
already being translated.
http://cr.opensolaris.org/~jmr/um_6358_release_notes_url_only_01April_630pm/
6358 Release Notes message after Update All needs to be updated
7353 Release notes URL should be clickable
Takeshi can you make sure this webrev would have no l10n impact.
A few things:
gui/modules/misc.py:
The danger I see with this is that /etc/release isn't meant to be
parsed (not an interface). So this code is fairly fragile in that
regard. However, I don't know of another option for the moment...
Yep I know, but couldn't see any other way to get this info.
line 91: EnvironmentError might be better than IOError.
Ok
line 92: file_obj might not be defined if the open failed
Ok
Long-term, we might want to put this into the 'entire' package and
set a info.marketing_release or some such attribute.
Yep sounds more robust - post 2009.06.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
