Here's a fourth webrev for this one:

 http://cr.opensolaris.org/~richb/pkg-7588-v4/

Changes from the previous one:

1/ Jeff Cai has determined that SUNWpython-lxml should not be a
  dependency for the SUNWavant package, so that line has been
  removed from .../111/i386/SUNWavant

2/ The new .../111/i386/SUNWcompiz is the same as the
  .../110/i386/SUNWcompiz file, so it's not needed. It's
  missing dependencies will be automatically found by the
  fix that Bart integrated for bug #7656. See:
  http://defect.opensolaris.org/bz/show_bug.cgi?id=7588#c0
  for more details.

There is another "just the diffs" file at:

  http://cr.opensolaris.org/~richb/pkg-7588-v4/7588-diffs.txt

so it's easier to see what's changed.

Thanks.

-------- Original Message --------
Subject: Re: [pkg-discuss] Code review request for opensolaris packaging bug #7588]
Date:   Thu, 02 Apr 2009 08:52:14 -0700
From:   Rich Burridge <[email protected]>
To:     Rich Burridge <[email protected]>
CC:     David Comay <[email protected]>
References:     <[email protected]>



New webrev for the fixes for bug #7588 at:

http://cr.opensolaris.org/~richb/pkg-7588-v3/

Bart requested that I should use a depend_path line rather
than a depend line where it makes sense, so I've adjusted
the code to remove those unneeded depend lines and replace
them with the following:

* Add a depend_path line for /usr/lib/amd64/pkgconfig/dbus-1.pc to
.../111/common/SUNWdbus-bindings

* Add in a depend_path line for /usr/bin/gconftool-2 to
.../111/common/SUNWdesktop-cache

* Add in a depend_path line for /usr/bin/gtk-update-icon-cache to
.../111/common/SUNWdesktop-cache

* Add in a depend_path line for /usr/bin/update-mime-database to
.../111/common/SUNWdesktop-cache

* Add in a depend_path line for /usr/share/man/man3/libebook-1.2.3 to
.../111/common/SUNWevolution-data-server

* Add in a depend_path line for /usr/bin/xsltproc to
.../111/common/SUNWgnome-common-devel

* Add in a depend_path line for /usr/bin/openjade to
.../111/common/SUNWgnome-common-devel

* Add in a depend_path line for /usr/bin/linc-cleanup-sockets to
.../111/common/SUNWgnome-dtstart

* Add in a depend_path line for /usr/bin/less to
.../111/common/SUNWgnome-gvfs

* Add in a depend_path line for /usr/bin/xmlcatalog to
.../111/common/SUNWgnome-xml

* Add in a depend_path line for /usr/share/man/man3/libgtkmm-2.4.3 to
.../111/common/SUNWpangomm

There is also a new "just the diffs maam" file at:

  http://cr.opensolaris.org/~richb/pkg-7588-v3/7588-diffs.txt

so it's easier to see what's changed.

Thanks.

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to