Hi all,
I've been told that it's preferable to edit existing IPS
package files in-situ, irrespective of what build number
they were for.
If that's the case, then here's a much simpler webrev for
this bug fix:
http://cr.opensolaris.org/~richb/pkg-7588-v8/
(And there's no need for the "just the diffs" file any more).
If it's not the case, then hopefully the webrev below (v7)
is the one we need.
Danek, could you please verify which is the best/correct
approach?
Thanks.
-------- Original Message --------
Subject: Re: [pkg-discuss] Code review request for opensolaris
packaging bug #7588]]]]
Date: Fri, 10 Apr 2009 10:31:14 -0700
From: Rich Burridge <[email protected]>
To: pkg discuss <[email protected]>, David Comay
<[email protected]>
Hi all,
David responded to my via email. Based on that email,
here's a seventh webrev for this bug:
http://cr.opensolaris.org/~richb/pkg-7588-v7/
The new "just the diffs" file at:
http://cr.opensolaris.org/~richb/pkg-7588-v7/7588-diffs.txt
Changes from last one:
* No longer added in the suggested dependencies for:
SUNWgnome-base-libs
SUNWgnome-file-mgr
SUNWclutter and
SUNWclutter-gst
As Alan pointed out below, these are brought in by other means.
* Removed the two occurrences of a dependency on a man page
that's in another package:
SUNWevolution-data-server
SUNWpangomm
* Adjusts an existing post-build #101 IPS package definition
file where possible, rather than create a new one.
Unfortunately that is just one file:
.../108/common/SUNWavahi-bridge-dsd
All the rest are from package files created before the OpenSolaris
2008.11 release.
* Adds new files into 111a/[common,i386] rather than under 111
(files hg cp'ed from their old versions).
Thanks.
-------- Original Message --------
Subject: Re: [pkg-discuss] Code review request for opensolaris
packaging bug #7588]]]
Date: Thu, 09 Apr 2009 23:04:00 -0700
From: Rich Burridge <[email protected]>
To: Alan Coopersmith <[email protected]>, David Comay
<[email protected]>
CC: pkg discuss <[email protected]>
Thanks for looking at this again Alan.
From talking with Bart and David, I don't believe we should be adding in
depend_path lines for version specific Python or Perl files. See:
http://defect.opensolaris.org/bz/show_bug.cgi?id=7588#c16
for my analysis of that. We should use 'depend <package name>' instead.
So looking at your list below, I believe that leaves the removal of changes
for:
SUNWgnome-base-libs
SUNWgnome-file-mgr
SUNWclutter and
SUNWclutter-gst
Rather than generate yet another webrev, I'd like for David (Comay), who
has final say on all this anyway, to chime in and state what changes (if
any), he'd still like to see. Or even if he'd prefer to wait until after
2009.06 before these changes are committed.
-------- Original Message --------
Subject: Re: [pkg-discuss] Code review request for opensolaris
packaging bug #7588]]
Date: Thu, 09 Apr 2009 21:17:00 -0700
From: Alan Coopersmith <[email protected]>
To: Rich Burridge <[email protected]>
CC: David Comay <[email protected]>, pkg discuss
<[email protected]>
References: <[email protected]> <[email protected]>
<[email protected]> <[email protected]>
<[email protected]> <[email protected]>
<[email protected]>
Rich Burridge wrote:
So here's webrev #6:
http://cr.opensolaris.org/~richb/pkg-7588-v6/
Since I was responsible for the original list, I've gone back and
checked against the output of my script and against the depends
already in the IPS packages on the machine I image-updated to build 111
today. It looks pretty good - there's only a couple of corrections I
think you need to make, some of which are dropping unneeded changes.
I've also listed the file dependencies where I know them, if you want to
prepare for package renaming by using depend_paths instead, though
for the python/perl modules, I wonder if that's just shifting the later update
effort to having to update /usr/lib/python2.4 -> /usr/lib/python2.5 and
/usr/lib/perl-5.8.4 -> /usr/lib/perl-5.10.x in the depend_path lines.
It would be nice if someday, many months from now, packages with interpreters
could list an attribute that specified their default search path, and then
scripts could list their dependencies relative to that search path, so when
they're updated from #! /usr/bin/python2.4 to #! /usr/bin/python2.5 the IPS
package build just did the right thing for their dependencies.
SUNWavahi-bridge-dsd:
depend SUNWdbus-bindings
could be replaced by
depend_path /usr/lib/python2.4/vendor-packages/dbus/glib.pyc
(dependency of /usr/bin/avahi-discover)
(The vncviewer depend isn't from my script - I assume it depends
on /usr/bin/vncviewer but don't know for sure.)
SUNWdbus-bindings:
It looks like the underlying root cause is that when libdbus
was split out of SUNWdbus into SUNWdbus-libs in build 99,
SUNWdbus-devel was left being pulled into SUNWdbus, but should
probably have been moved to SUNWdbus-libs as well, since right now
the headers for the libraries in SUNWdbus-libs are in SUNdbus.
That's probably something to fix after 2009.06 though, so I've filed
a new bug to do that then (or at least in a different webrev/commit
than this one):
http://defect.opensolaris.org/bz/show_bug.cgi?id=8088
SUNWgnome-a11y-poke:
depend SUNWgnome-python-libs
could be replaced by
depend_path /usr/lib/python2.4/vendor-packages/pygtk.pyc
depend SUNWIpython seems to be a typo - I don't see where this
dependency came from. My script & the bug report suggest adding
SUNWPython (without the I), but bart's #! fix should already cover that.
SUNWgnome-a11y-reader:
depend SUNWgnome-python-libs
could be replaced by
depend_path /usr/lib/python2.4/vendor-packages/pygtk.pyc
From reading /usr/bin/orca, it looks like it could also use
depend_path /usr/X11/bin/xmodmap
depend_path /usr/bin/gconftool-2
depend_path /usr/bin/gnome-terminal
for completeness - but you probably know better than anyone else here
if Orca will break if any of those aren't found. 8-)
SUNWgnome-base-libs:
The IPS packages already depend on SUNWpixman & SUNWuiu8.
SUNWpixman was a library dependencies missing from the SVR4 packages
that IPS autodetected, so you shouldn't need to add it here - SUNWuiu8
is already in the 76/common/SUNWgnome-base-libs, so this file can be
dropped.
SUNWgnome-doc-utils
depend SUNWlxml
could be replaced by
depend_path /usr/lib/python2.4/vendor-packages/libxml2.py
SUNWgnome-file-mgr
The libzfs dependency is already picked up by IPS so the SUNWzfs depend is
already present, so this file can be dropped.
SUNWgnome-games
depend SUNWgnome-python-desktop
could be replaced by
depend_path /usr/lib/python2.4/vendor-packages/gtk-2.0/bugbuddy.pyc
There should also be a
depend_path /usr/lib/python2.4/vendor-packages/pygtk.pyc
or
depend SUNWgnome-python-libs
for the SUNWgnome-python-libs dependency that got lost somewhere.
SUNWgnome-gui-test
depend SUNWgnome-python-libs
could be replaced by
depend_path /usr/lib/python2.4/vendor-packages/gtk-2.0/gtk/keysyms.pyc
SUNWgnome-img-editor:
depend SUNWgnome-python-libs
could be replaced by
depend_path /usr/lib/python2.4/vendor-packages/pygtk.pyc
SUNWgnome-system-tools:
depend SUNWperl-authen-pam
could be replaced by
depend_path /usr/perl5/vendor_perl/5.8.4/i86pc-solaris-64int/Authen/PAM.pm
SUNWgnome-themes
depend SUNWperl-xml-parser
could be replaced by
depend_path /usr/perl5/vendor_perl/5.8.4/XML/Simple.pm
SUNWgst-python:
depend SUNWgnome-python-libs
could be replaced by
depend_path /usr/lib/python2.4/vendor-packages/pygtk.pyc
SUNWterminator:
depend SUNWgnome-python-libs
could be replaced by
depend_path /usr/lib/python2.4/vendor-packages/pygtk.pyc
SUNWavant:
depend SUNWgnome-python-libs
could be replaced by
depend_path /usr/lib/python2.4/vendor-packages/pygtk.pyc
SUNWclutter:
Already depends on SUNWxorg-mesa, from the IPS detection of the libGL.so.1
dependency in libclutter-glx-0.8.so so you should be able to drop this file.
SUNWclutter-gst:
Already depends on SUNWgnome-media, from the IPS detection of the
libgstreamer-0.10.so.0 dependency in libclutter-gst-0.8.so so you should
be able to drop this file.
--
-Alan Coopersmith- [email protected]
Sun Microsystems, Inc. - X Window System Engineering
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
