LGTM.
Thanks.
Tom
Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issues:
8102 pkg.client.api info reports size of zero for packages with
cached manifests
webrev:
http://cr.opensolaris.org/~swalker/pkg-8102/
This is happening regardless of architecture and is a result of the
CachedManifest work that was recently done, and so is broken in the
API and not in any specific client.
The fix was to add a get_size method to Manifest/CachedManifest that
takes a list of excludes and returns the size in bytes for the data
payloads of the resulting action set and remove the obsolete size
attribute from the Manifest classes. The public client API and
internal APIs have been changed to use this new function.
Finally, the t_api_info unit tests were updated to ensure that this
doesn't happen again.
Cheers,
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[email protected]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
