[email protected] wrote:
On Mon, Apr 13, 2009 at 07:53:07PM -0700, Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-8003-v1/
client/query_parser.py:
- line 254: Why is it that this code catches the
InconsistentIndexException and then throws a new
InconsistentIndexException with the previous one as its data.
Wouldn't it just be simpler to eliminate these handlers and let the
original exception go through?
Notice that it changes from a search_error to an api_error. Because of
the joys of generator functions, this was about the only place I could
find to reliably catch the search_error.InconsistentIndexException. Does
that help clarify things?
Thanks for taking a look,
Brock
Otherwise this looks okay to me.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
