LGTM
Michal
Padraig O'Briain wrote:
I have respun the webrev, http://cr.opensolaris.org/~padraig/ips-8177-v3/.
Padraig
On 04/15/09 11:11, jmr wrote:
+1, one minor nit:
if (self.w_info_notebook.get_current_page() == 3
Would be clearer to have meaningful global variable names or enum for
these page numbers.
JR
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-8177-v2/, fixes
8177 Install/Uninstall PM gets traceback
The removal of line 2942
self.selected_pkgstem = None
fixes the reported problem.
The other changes in __show_info_after_catalog_load avoid retrieving
licenses unnecessarily.
The changes in __show_licenses and __show_package_licenses avoids
problems if self.selected_pkgstem is changed by not referring to it
in a thread.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
