Thanks for taking a look and yep that's correct "if this conversion
fails, then the date_time will simply stay unconverted", seems the right
thing to do.
Note: I am still having problems with the new webrev tool adding the '
at the end of the posts on the generated web page, as Shawn suggested I set:
export SED=/usr/bin/sed
Before running:
/opt/onbld/bin/webrev
So the full patch is at:
http://cr.opensolaris.org/~jmr/pm_8182_r2_15April_330pm/ips_gate.patch
Not at:
http://cr.opensolaris.org/~jmr/pm_8182_r2_15April_330pm/ips_gate.patch'
JR
Michal Pryc wrote:
John,
If the localization *po files are correct the changes in the beadm.py,
prototype and PROFILES.in looks fine for me.
The only question I could have is about the file:
http://cr.opensolaris.org/~jmr/pm_8182_r2_15April_330pm/src/gui/modules/beadmin.py.wdiff.html
- line 556, if this conversion fails, then the date_time will simply
stay unconverted. Am I right?
best
Michal
jmr wrote:
Takeshi - when running PM as I did below the code in beadmin.py (line
542) has hit the following python issue:
1443504 locale.getpreferredencoding() dies when setlocale fails
http://bugs.python.org/issue1443504
I have modified beadmin.py to work around the issue and fall back to
the default date format (note: there was also an indentation bug
there causing us to always use the default). I changed the last
POTFILE.in entry ordering as Padraig suggested. Webrev is below:
http://cr.opensolaris.org/~jmr/pm_8182_r2_15April_330pm/
If you are happy with this I can land it tomorrow before B3.
JR
Takeshi - I tried this out using:
$ LC_ALL=fr pfexec packagemanager
and it came up and worked for the most part.
Issues:
- Plenty of translation issues which I assume will be there for B4,
Legend, most of the Dialogs, in the Install I saw some of the bullet
points not translated, but as you progressed they changed to
translated strings.
- Boot Environment Manager, this dialog does come up but I get a
traceback and no BE's listed:
Traceback (most recent call last):
File "/usr/lib/python2.4/vendor-packages/pkg/gui/beadmin.py", line
542, in __create_view_with_be
"utf-8").encode(
File "/usr/lib/python2.4/locale.py", line 417, in getpreferredencoding
setlocale(LC_CTYPE, "")
File "/usr/lib/python2.4/locale.py", line 381, in setlocale
return _setlocale(category, locale)
locale.Error: unsupported locale setting
/var/pkg/state$
I will look into it.
JR
Padraig O'Briain wrote:
The entries in the file POTFILE.in should be in alphabetical order
according to the comments at the top of the file.
The entry you added at line 29 should be at line 9.
Padraig
On 04/15/09 12:04, Takeshi Asano wrote:
Hi,
Could you please review this webrev for 8182 (l10n update at B3)?
http://defect.opensolaris.org/bz/show_bug.cgi?id=8182
http://cr.opensolaris.org/~asano/pkg-8182-v1/
Thanks,
Takeshi
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
