Danek Duvall wrote:
On Tue, Apr 14, 2009 at 06:42:01PM -0700, Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-8098-v1/
{client,server}/query_parser.py:
- Why are you importing BooleanQueryException and ParseError here if
you're not using them anywhere?
They're used in {client, server}/api.py. Doing it this way means those
modules only need to import their query_parser, rather than both theirs
and the pkg.query_parser one. (It was the alternative to making a stub
subclass which I had done in the past b/c I had forgotten/didn't know
you could do things this way.)
query_parser.py:
- line 250: be consistent about tag capitalization. I prefer lower-case,
but maybe we're mostly upper-case elsewhere.
You're right. The docs I looked at used uppercase so I just went with
uppercase, I'll switch those to lowercase.
Thanks for taking a look :)
Brock
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
