On 04/16/09 09:39, jmr wrote:
Padraig - what's the performance impact of altering update_package_list() in packagemanager.py, in particular on larger repos such as pending?

My change only acts on the list of packages which have just been installed or removed. This change should have no performance impact which depends on the size of the repository.


Are there other instances in the code that use the branch info from an api.info call without checking if its been set?

The only places I found branch being referred to was in strings in packagemanager.py and updatemanager.py and these worked OK.

Padraig
JR

Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-7866-v1/, fixes
7866 packagemanager install failure with pre-released adobe reader package

The change in installupdate.py avoids the stack trace when pkg_info.branch is not set. The change in packagemanager.py is to ensure that the package is reported as installed.

Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to