On Tue, Apr 21, 2009 at 06:04:11PM -0500, Shawn Walker wrote:
> Rich Burridge wrote:
>>
>> Hi all,
>>
>> Looking for a code review of the proposed changes for bug #8132:
>>
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=8132
>> __licenses should use StringIO
>>
>> Webrev is at:
>> http://cr.opensolaris.org/~richb/pkg-8132-v1/
>>
>> I note that the license information appears more than once,
>> but it did that before I made my change too.
>
> I'd use cStringIO instead, but other than that, looks fine.
There's a catch to using cStringIO if you're not handling plain ASCII.
I saw the following paragraph in the cStringIO documentation:
Unlike the memory files implemented by the StringIO module,
those provided by this module are not able to accept Unicode
strings that cannot be encoded as plain ASCII strings
(http://www.python.org/doc/2.4.4/lib/module-cStringIO.html)
If licenses are only in ASCII, then cStringIO would be preferable.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
