Ok thanks, I've tested it and the Help looks fine with the explanation
of the changes in the Search All Repos there. I checked the earlier
functionality on the search which this new webrev hadn't changed and its
all fine.
JR
Padraig O'Briain wrote:
Looks good to me.
Padraig
On 04/22/09 18:44, jmr wrote:
Padraig - I've just got Jyothi's update to the help can you look at
the new webrev.
http://cr.opensolaris.org/~jmr/pm_8335_8336_search_all_22April_640pm/
Thanks,
JR
Padraig O'Briain wrote:
Looks good to me.
On 04/22/09 14:51, jmr wrote:
Padraig spoke too soon. I went back and rechecked all the
__process_after_search_failure() calls and there is one we do want
to handle the same way. That is when we have problematic search
servers. So I have respun and call a new func to handle searches
with zero results in both instances, I have left the other error
condition handlers as they are. Tried this out using
opensolaris.org and blastwave. The search all resets things nicely
now after a search with zero results.
http://cr.opensolaris.org/~jmr/pm_8335_8336_search_all_22April_240pm/
JR
jmr wrote:
Padraig O'Briain wrote:
I have not tested this yet but I have a query about the change at
line 1519, i.e. the replacement of the call to
__process_after_search_failure().
There are other places in do_remote_search where
__process_after_search_failure. Do these also need to be changed?
I think when you get 0 results it is not correct to be using the
__process_after_search_failure(), the search succeeded it just
didn't find anything. The other instances are genuine failures and
should be reported as such, in those cases leaving the previous
results seems OK to me as the user will see an error dialog and
realize something is wrong.
JR
Padraig
On 04/22/09 11:56, jmr wrote:
Hi here is a webrev to change the default PM Search All Repos to
match the CLI default search. This gives us a further x2
increase in speed and makes the searching consistent as users
are doing an exact match search across all package actions in
both cases. Users can always add wild card '*' to the search
term if they want and restrict it to description if they need to
as well, though this will slow down searching.
There are some minor PM text changes and changes to Help
required because of this change, but l10n and Doc are happy to
do this for B4. Some suggested text for Help is in the 8335 bug.
8335 Search All Repositories should match CLI default search
behavior
8336 PM Search All Repositories is not clearing old search
result when no matches found
webrev (not including OLH changes):
http://cr.opensolaris.org/~jmr/pm_8335_8336_search_all_22April_1140am/
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
